Closed
Conversation
…en calling hiera_array and hiera_hash should return all results from all backends
…, an empty data structure ("", [] or {}) will be returned.
lib/hiera/backend/yaml_backend.rb
Outdated
Contributor
There was a problem hiding this comment.
Is this not a change in behaviour?
>> foo = {:foo => 'foo'}
>> bar = {:foo => 'bar'}
>> foo = bar.merge foo
=> {:foo=>"foo"}
>> foo = {:foo => 'foo'}
>> bar = {:foo => 'bar'}
>> foo.merge! bar
=> {:foo=>"bar"}
Author
There was a problem hiding this comment.
Yes, you're right. The first value found shouldn't be overridden.
lib/hiera/backend.rb
Outdated
There was a problem hiding this comment.
This fails if answer is nil:
err: undefined method `empty?' for nil:NilClass
empty? is also not defined for TrueClass or FalseClass it seems.
Author
There was a problem hiding this comment.
You're right, thanks for pointing that out. I pushed a fix for it.
|
@carlasouza Looks like we should try and rebase this on master, then it will be ready for review. Let me know if you need help rebasing this. |
|
@carlasouza This should now be fixed: e6d57c0411d8d3c97053752375c94dba40c2d2ab |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lookup method cannot return nil in case there isn't an available answer. Instead, an empty data structure ("", [] or {}) will be returned. Also, calling hiera_array and hiera_hash should return all results from all backends.