(maint) Refactor DMI data source #11
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the DMI data source collected data in its constructor, so even when DMI wouldn't have been used anyway, it would still try to collect its data from dmidecode and /sys on instantiation. This commit changes the DMI source so that it only collects data when one of data values is accessed.
caseywilliams
force-pushed
the
dmi-refactor
branch
from
588c7f5 to
bc550a4
Compare
Contributor
Author
|
Hmm, I bet I could get back some of the coverage here by including a new method that just returns the contents the dmidecode output. I'll update soon. |
Contributor
Author
|
I had to do a little more work on DMI to get WMI working under Windows, so I'm closing this PR in favor of including this and the new changes in a separate one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the DMI data source collected data in its constructor, so
even when DMI wouldn't have been used anyway, it would still try to
collect its data from dmidecode and /sys on instantiation. This commit
changes the DMI source so that it only collects data when one of data
values is accessed.