Skip to content

Conversation

@caseywilliams
Copy link
Contributor

@caseywilliams caseywilliams commented Sep 11, 2017

Adds a detector function for Solaris LDoms that is called on sparc
platforms only. Relies on the virtinfo executable (like facter).
Example output:

  ldom => {
    chassis_serial => "AK00358110",
    control_domain => "opdx-a0-sun2",
    domain_name => "sol11-2",
    domain_uuid => "f6c6e7ba-9092-42b2-9604-8ff289bb712a",
    role_control => false,
    role_io => false,
    role_root => false,
    role_service => false
  }

This will need another PR to puppet-agent once merged so that the agent will actually build whereami on Solaris - it worked in a test build I did today.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.03%) to 93.605% when pulling 4f45926 on caseywilliams:ldom-detector into d564198 on puppetlabs:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.03%) to 93.605% when pulling 74a8ecd on caseywilliams:ldom-detector into d564198 on puppetlabs:master.

@caseywilliams
Copy link
Contributor Author

Coverage keeps going down for these commits that rely on checking for some external executable - if anyone has ideas about how to make these more thoroughly testable, I'm all ears.

@branan
Copy link
Contributor

branan commented Sep 18, 2017

I think as long as we have good coverage of the parse functions, I'm not too worried about losing a bit of coverage around actually calling each executable. Such is life.

@branan
Copy link
Contributor

branan commented Sep 25, 2017

It'd be good to have a fixture for virtinfo output on a non-ldom host. We can talk to ops if we don't have access to such a thing directly. Other than that I'm 👍 to this after a rebaes

@caseywilliams caseywilliams force-pushed the ldom-detector branch 3 times, most recently from 91fe30a to a6a3327 Compare September 25, 2017 20:43
@caseywilliams
Copy link
Contributor Author

@branan rebased and updated with some virtinfo output from an LDom control machine. When LDoms aren't available (e.g. on x86), the virtinfo -a -p flags aren't available either; Those will automatically be counted as negative results when the command fails - I can't really write a test for that case, though.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 91.087% when pulling a6a3327 on caseywilliams:ldom-detector into abd5e9f on puppetlabs:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 91.087% when pulling a6a3327 on caseywilliams:ldom-detector into abd5e9f on puppetlabs:master.

@branan
Copy link
Contributor

branan commented Sep 29, 2017

This looks good now, once it's rebased 👍

Adds a detector function for Solaris LDoms that is called on sparc
platforms only. Relies on the `virtinfo` executable.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 91.005% when pulling 10aca09 on caseywilliams:ldom-detector into 4094cee on puppetlabs:master.

@branan branan merged commit 50c9fe2 into puppetlabs:master Sep 29, 2017
@caseywilliams caseywilliams deleted the ldom-detector branch November 7, 2017 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants