-
Notifications
You must be signed in to change notification settings - Fork 16
(FACT-1661) Add Solaris LDom detector #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4f45926 to
74a8ecd
Compare
|
Coverage keeps going down for these commits that rely on checking for some external executable - if anyone has ideas about how to make these more thoroughly testable, I'm all ears. |
|
I think as long as we have good coverage of the parse functions, I'm not too worried about losing a bit of coverage around actually calling each executable. Such is life. |
|
It'd be good to have a fixture for virtinfo output on a non-ldom host. We can talk to ops if we don't have access to such a thing directly. Other than that I'm 👍 to this after a rebaes |
91fe30a to
a6a3327
Compare
|
@branan rebased and updated with some |
|
This looks good now, once it's rebased 👍 |
Adds a detector function for Solaris LDoms that is called on sparc platforms only. Relies on the `virtinfo` executable.
a6a3327 to
10aca09
Compare
Adds a detector function for Solaris LDoms that is called on sparc
platforms only. Relies on the
virtinfoexecutable (like facter).Example output:
This will need another PR to puppet-agent once merged so that the agent will actually build whereami on Solaris - it worked in a test build I did today.