Skip to content

Conversation

@caseywilliams
Copy link
Contributor

Checks that WMI query object results are not empty before attempting to
get values out of them.

Checks that WMI query object results are not empty before attempting to
get values out of them.
@coveralls
Copy link

Coverage Status

Coverage increased (+2.1%) to 97.423% when pulling cf876fd on caseywilliams:fix-wmi into 6d2e968 on puppetlabs:master.

@MikaelSmith
Copy link
Contributor

This seems to make sense. I'll incorporate it in a Windows build I'm running now.

@MikaelSmith
Copy link
Contributor

Should this be targeted at 0.1.x?

@caseywilliams caseywilliams changed the base branch from master to 0.1.x September 13, 2017 23:45
@caseywilliams
Copy link
Contributor Author

Oops, yes - retargeted

@MikaelSmith
Copy link
Contributor

Works for the openstack environment, and detects hypervisors => { kvm => { openstack => true } }. 👍

@MikaelSmith MikaelSmith merged commit db0d36e into puppetlabs:0.1.x Sep 14, 2017
@caseywilliams caseywilliams deleted the fix-wmi branch November 7, 2017 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants