Skip to content

15708 pkgbuild#87

Closed
mrzarquon wants to merge 3 commits intopuppetlabs:masterfrom
mrzarquon:15708_pkgbuild
Closed

15708 pkgbuild#87
mrzarquon wants to merge 3 commits intopuppetlabs:masterfrom
mrzarquon:15708_pkgbuild

Conversation

@mrzarquon
Copy link

Enables flat package building for apple systems, which then allows for signed packages.

Will also execute the postflight script if present to create puppet user on the system.

If run with the sign var set to true, it will sign packages if the proper certificates are present on the machine.

Chris Barker added 2 commits December 7, 2012 14:40
Enables building using pkgbuild command which allows for packages to be
signed by productsign once it passes qa.

Previously used PackageMaker, which is the depreciated tool for building
packages.

Adds postflight script to create puppet users

Removes preflight script, users will have to remove previous version of
puppet prior to installing this.

Checks for postflight.erb before trying to install it

Sets postflight to be executable
postflight scripts no longer executed with flat packages, renamed to
postinstall for compatibility. will now use a .erb file if found.

previous behavior would create the postflight script, but installer
wouldn't execute it.

adds support for signing packages if flag is set prior to rake task

note: files.yaml needs to be updated to use /private prefix on specific
directories before this build task will work on 10.5.x machines,
currently fixed with facter in this pull request:

puppetlabs/facter#374
tasks/apple.rake Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to enable overriding this value with an environment variable, so non-puppet labs users who want to build & sign their own apple packages (and have their own signing key) can still use this.

enables checks against env variables for signing the package and the
developer ID to use. defaults to no signing and puppetlabs ID if used
(if machine does not have correspending certificates, it will generate
an unsigned package).

previous behavior had hard coded values that couldn't be overriden with
ENV.
@mrzarquon
Copy link
Author

@MosesMendoza I've updated the commit to reflect those original comments.

@puppetcla
Copy link

Waiting for CLA signature by @mrzarquon

@mrzarquon - We require a Contributor License Agreement (CLA) for people who contribute to Puppet, but we have an easy click-through license with instructions, which is available at https://cla.puppetlabs.com/

Note: if your contribution is trivial and you think it may be exempt from the CLA, please post a short reply to this comment with details. http://docs.puppetlabs.com/community/trivial_patch_exemption.html

@puppetcla
Copy link

CLA signed by all contributors.

@MosesMendoza
Copy link
Contributor

We have switched to flat packages and will be evaluating signing in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants