This repository was archived by the owner on Apr 17, 2023. It is now read-only.
Conversation
jpogran
force-pushed
the
pdk-new-cmd
branch
2 times, most recently
from
c9a5b56 to
79740ad
Compare
4 tasks
jpogran
force-pushed
the
pdk-new-cmd
branch
2 times, most recently
from
5752d5a to
43639c9
Compare
Closed
jpogran
force-pushed
the
pdk-new-cmd
branch
9 times, most recently
from
755ab1b to
2576679
Compare
jpogran
force-pushed
the
pdk-new-cmd
branch
3 times, most recently
from
29b6543 to
1cd9b58
Compare
Creates the pct golang package which allows users to list and deploy Puppet Content Templates. There is much more to implement, but this is the start. It can list and format the display of the PCTs installed on a local filesystem. This shows PCT details like id and names and provides autocomplete functionality for the shell commands. It can deploy a selected template to a target file path based on the `pct-config.yml` configuration file inside the PCT and from the `~/.pdk/pct.yml` user level configuration file.
Removes all subcomands for `pdk new` and adapts `pdk new` to use the PCT golang package. The unit tests for `pdk new` pass but do not actually test any PCT functionality. Tests for PCT functionality are inside the PCT package. A future work item is to either adapt a unit test that can accurately exercise the command line here, or add that as an acceptance test instead.
Sets the binary name to `pct` to reflect that this is currently an experiment of the PCT system. This also ensures that use of this binary does not conflict with the shipped PDK command name until we start shipping the final form. Updates goreleaser config file to set the version, short commit hash, and commit date inside the binary as its compiled. This enables accurate deployment information in `pdk --version` as well as for use inside templates.
4 tasks
da-ar
approved these changes
May 14, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates the pct golang package which allows users to list and deploy Puppet Content Templates and modifies the
newcommand to list and deploy PCTs.There is much more to implement, but this is the start. This can list and format the display of the PCTs installed on a local filesystem. It shows PCT details like id and names and provides autocomplete functionality for the shell commands. It can deploy a selected template to a target file path based on the
pct-config.ymlconfiguration file inside the PCT and from the~/.pdk/pct.ymluser level configuration file.This also changes the binary name to
pctto reflect that this is currently an experiment of the PCT system. This also ensures that use of this binary does not conflict with the shipped PDK command name until we start shipping the final form. Lastly this updatesgoreleaser.ymlto set the version, short commit hash, and commit date inside the binary as its compiled. This enables accurate deployment information inpdk --versionas well as for use inside templates.