Unit test updates #15
Conversation
This commit updates the nightly unit test workflow to use the setup-ruby action's built-in bundler-cache job to install gems. See also: puppetlabs/puppet@86820ee
|
Tested here: puppetlabs/puppetlabs-augeas_core#82 |
| run: | | ||
| git config --global core.longpaths true | ||
| bundle config set system 'true' | ||
| bundle config set --local without 'release' |
There was a problem hiding this comment.
Does it matter that we lost these configurations? It's possible to set these as environment variables (at least for the latter two, not sure about global git config)?
There was a problem hiding this comment.
I don't think we need the longpaths configuration anymore--it was initially implemented because of the GitHub Changelog Generator repo: puppetlabs/puppetlabs-augeas_core#35
But we no longer use that Changelog Generator anymore, so I don't think we need the option.
This action is used by the core modules and the puppet_agent module, none of which have a "release" group in their Gemfiles. We won't lose anything by removing this configuration.
The Bundler docs don't seem to have anything on bundle config set system 'true', but it seems like it sets all future Bundler configuration to take place at the system level (as opposed to local/global). If that's the case, then we're not doing any additional Bundler configuration so it doesn't matter anyway.
2 participants
This PR updates the setup-ruby action to use bundler-cache (as first implemented in Puppet here) and updates the FFI gem to the latest known good version.