Loading of Puppet Types/Functions etc. should rescue errors and not crash

[glennsarti]

From - puppetlabs/puppet-vscode#349

What Versions are you running?

OS Version: N/A
VSCode Version: N/A
Puppet Extension Version: 0.11.0
Puppet Agent Version: N/A
PDK Version (if applicable): N/A

What You Are Seeing?

D, [2018-08-13T16:11:23.271452 #9328] DEBUG -- : [PUPPET LOG] [err] Could not autoload puppet/parser/functions/hiera.rb: cannot load such file -- hiera
E, [2018-08-13T16:11:23.273468 #9328] ERROR -- : [PuppetHelper::_load_default_functions] Error loading function puppet/parser/functions/hiera.rb: Could not autoload puppet/parser/functions/hiera.rb: cannot load such file --
 hiera ["C:/Program Files/Puppet Labs/Puppet/sys/ruby/lib/ruby/2.4.0/rubygems/core_ext/kernel_require.rb:55:in require'",
 "C:/Program Files/Puppet Labs/Puppet/sys/ruby/lib/ruby/2.4.0/rubygems/core_ext/kernel_require.rb:55:inrequire'",
 "C:/Program Files/Puppet Labs/Puppet/sys/ruby/lib/ruby/vendor_ruby/hiera_puppet.rb:1:in <top (required)>'",
 "C:/Program Files/Puppet Labs/Puppet/sys/ruby/lib/ruby/2.4.0/rubygems/core_ext/kernel_require.rb:55:inrequire'",
 "C:/Program Files/Puppet Labs/Puppet/sys/ruby/lib/ruby/2.4.0/rubygems/core_ext/kernel_require.rb:55:in require'",
 "C:/Program Files/Puppet Labs/Puppet/sys/ruby/lib/ruby/vendor_ruby/puppet/parser/functions/hiera.rb:1:in<top (required)>'",
 "C:/Program Files/Puppet Labs/Puppet/sys/ruby/lib/ruby/vendor_ruby/puppet/util/autoload.rb:68:in load'",
 "C:/Program Files/Puppet Labs/Puppet/sys/ruby/lib/ruby/vendor_ruby/puppet/util/autoload.rb:68:inload_file'",
 "C:/Program Files/Puppet Labs/Puppet/sys/ruby/lib/ruby/vendor_ruby/puppet/util/autoload.rb:194:in load'",
 "c:/Users/mchen6/My Programs/VS Code/data/extensions/jpogran.puppet-vscode-0.11.0/vendor/languageserver/lib/puppet-languageserver/puppet_helper.rb:364:inload_function_file'",
 "c:/Users/mchen6/My Programs/VS Code/data/extensions/jpogran.puppet-vscode-0.11.0/vendor/languageserver/lib/puppet-languageserver/puppet_helper.rb:424:in block in _load_default_functions'",
 "c:/Users/mchen6/My Programs/VS Code/data/extensions/jpogran.puppet-vscode-0.11.0/vendor/languageserver/lib/puppet-languageserver/puppet_helper.rb:421:ineach'",
 "c:/Users/mchen6/My Programs/VS Code/data/extensions/jpogran.puppet-vscode-0.11.0/vendor/languageserver/lib/puppet-languageserver/puppet_helper.rb:421:in _load_default_functions'",
 "c:/Users/mchen6/My Programs/VS Code/data/extensions/jpogran.puppet-vscode-0.11.0/vendor/languageserver/lib/puppet-languageserver/puppet_helper.rb:71:inload_functions'",
 "c:/Users/mchen6/My Programs/VS Code/data/extensions/jpogran.puppet-vscode-0.11.0/vendor/languageserver/lib/puppet-languageserver/puppet_helper.rb:76:in `block in load_functions_async'"]

What is Expected?

It shouldn't crash

How Did You Get This To Happen? (Steps to Reproduce)

Output Log

[glennsarti]

e.g. https://github.com/lingua-pupuli/puppet-editor-services/blob/6eb083bd9aa11f3473c3fd97764edfd8ab6429aa/lib/puppet-languageserver/puppet_helper.rb#L377

[glennsarti]

Merged as part of sidecar. Closing.