(maint) Add tests for roundtripping hash serialisation #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the Sidecar Protocol had methods to convert to and from hash however they were never tested to ensure that they could be "round-tripped", that is converted to a hash and then back to a sidecar object with no loss of data. This commit adds the test and corrects any behvaiour in the protocol implementation.
glennsarti
force-pushed
the
test-hash-roundtrip
branch
from
5a57cae to
134cbd1
Compare
Contributor
Author
|
Self merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the Sidecar Protocol had methods to convert to and from hash however
they were never tested to ensure that they could be "round-tripped", that is
converted to a hash and then back to a sidecar object with no loss of data. This
commit adds the test and corrects any behvaiour in the protocol implementation.