(GH-167) Refactor Language Server inmemory caching #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennsarti
force-pushed
the
refactor-caching
branch
2 times, most recently
from
9bafabd to
455bcb0
Compare
Previously the message router called `DocumentStore.module_plan_file?` for the signature provider, however this method was renamed. This commit modifies the call to use the correct name of `.plan_file?`
Previously the test method was called create_mock_resource however it wasn't actually creating a resource, it created a type. This commit changes the name to be more meaningful
Previously the caching in the Language Server created and destroyed a lot of objects, in particular converting sidecar objects into cache objects, which is basically the same thing with a little decoration. This object creation/deletion isn't really needed and causes undue GC stress. This commit: * Changes the cache to use the Sidecar Protocol Objects directly which stops the needless creation and destruction of objects * Instead of adding the `origin` method to all cache objects, this commit uses hashtable "buckets" to remember which sections and and origins objects should be categorised as * Removes the PuppetHelper.all_objects method as it needlessly yields yeilded objects. Instead callers can use the cache directly * Removes the cache_objects source file and tests * Adds helpful frozen arrays in the cache class for valid sections and origins, although this is not yet enforced * Begins to change the providers to use the object cache as a parameter instead of through the PuppetHelper module. This is easier for testing. * Updates the completion, document_symbol and hover provider with the new cache object types and method removals.
Previously the workspace symbols method was added but there were not tests. This commit adds unit tests.
glennsarti
force-pushed
the
refactor-caching
branch
from
455bcb0 to
d57c24e
Compare
glennsarti
changed the title
Contributor
Author
|
Self merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #167
Previously the caching in the Language Server created and destroyed a lot of
objects, in particular converting sidecar objects into cache objects, which is
basically the same thing with a little decoration. This object creation/deletion
isn't really needed and causes undue GC stress.
This commit:
needless creation and destruction of objects
originmethod to all cache objects, this commit useshashtable "buckets" to remember which sections and and origins objects should
be categorised as
objects. Instead callers can use the cache directly
although this is not yet enforced
of through the PuppetHelper module. This is easier for testing.
object types and method removals.
Various other maintenance fixes as well.