(GH-199) Monkey Patch the Null Loader #200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
The Null Loader was removed in Puppet 6.11.0+ (and friends). This commit monkey patches the Null Loader back in if it doesn't exist.
glennsarti
force-pushed
the
fix-null-loader
branch
from
79bda49 to
fb3dea7
Compare
The Puppet call stack has changed behaviour for both exceptions and succesful calls. This commit updates the tests for expect different stack traces for exceptions, and updates the generate stack trace method to ignore call sites with invalid line numbers (e.g. 0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #199
The Null Loader was removed in Puppet 6.11.0+ (and friends). This commit monkey
patches the Null Loader back in if it doesn't exist.