(GH-189) Reset PuppetLint configuration for each call #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpogran
approved these changes
Jan 4, 2021
Contributor
|
@glennsarti can your rebase with main and push so we can have a CI run for this with the new github actions stuff |
Previously after a call to fix_validation_errors, many validation errors came in as hints not errors. This was due to PuppetLint not resetting the `PuppetLint.configuration.fix` setting between calls. This commit updates the validation provider to reset this setting each call. This commit also adds tests for this scenario.
glennsarti
force-pushed
the
fix-puppet-lint
branch
from
ee7f062 to
c70511b
Compare
Contributor
Author
|
@jpogran Done. You'll need to remove the Appveyor integration though as I (rightly) have no access there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #189
Previously after a call to fix_validation_errors, many validation errors came
in as hints not errors. This was due to PuppetLint not resetting the
PuppetLint.configuration.fixsetting between calls. This commit updates thevalidation provider to reset this setting each call. This commit also adds
tests for this scenario.