(GH-54) Support Puppet 6 in the Language Server #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennsarti
force-pushed
the
add-puppet-6
branch
3 times, most recently
from
3c154fb to
bad5709
Compare
glennsarti
changed the title
With the new puppet 6.0 gem, the type loading in the Language Server no longer worked. This was due autoloader methods changing their method signature. Given that this is a major version bump, breaking changes are not unexpected. This commit changes: * The file loader to always pass the environment parameter. Before Puppet 6 this was optional, but it is now a required parameter * The files_to_load method has changed from no parameters to one. This commit modifies the call to first check the arity of the method, i.e. how many parameters are needed, and then modifies the file_to_load call appropriately. Using arity is better than checking Puppet version as it takes into account Puppet 7 and beyond. Note that no test changes were made and this confirms that the language server behaviour is the same across Puppet 4,5 and 6.
With the new puppet 6.0 gem, the function loading in the Language Server no longer worked. This was due autoloader methods changing their method signature and the Puppet::Parser::Functions.environment_module(env) no longer working as expected. Given that this is a major version bump, breaking changes are not unexpected. This commit changes: * The monkey patching for functions now keeps track of which functions have been loaded through a simple hash table, and is accessible from Puppet::Parser::Functions.monkey_function_list * The array functions filenames.uniq!.compact! could cause nils being generated. By changing to filenames.uniq.compact we can guarantee that an empty array would be generated, not nils. * The file loader to always pass the environment parameter. Before Puppet 6 this was optional, but it is now a required parameter Note that no test changes were made and this confirms that the language server behaviour is the same across Puppet 4,5 and 6.
This commit updates the Appveyor and Travis CI configuration to test the language server on Puppet 6 and Ruby 2.5.1.
glennsarti
force-pushed
the
add-puppet-6
branch
from
bad5709 to
27e0bd7
Compare
Previously Puppet 4.7 was the minimum LTS version. However the latest version if PE 2016.4 includes agent 4.10. This commit removes the Puppet 4.7 testing as it is covered by the 4.x testing.
jpogran
approved these changes
Oct 3, 2018
glennsarti
force-pushed
the
add-puppet-6
branch
from
27e0bd7 to
2ffbbf9
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Language Server was broken for Puppet 6. This PR updates the language server for Puppet 6 support, while still supporting Puppet 4 and 5.
This PR also adds Puppet 6 to the testing matrix.
Fixes #54