Skip to content

Conversation

@jordanbreen28
Copy link

Prior to this PR, the version of the gem would need to be manually updated, pushed and merged into main each time before running release_prep.yml.
This PR introduces a "version" input parameter, that can be specified when running the workflow which eliminates the need for the above.

@jordanbreen28 jordanbreen28 added the feature New feature or request label Mar 6, 2023
@jordanbreen28 jordanbreen28 requested a review from a team as a code owner March 6, 2023 15:21
@ekohl
Copy link

ekohl commented Mar 6, 2023

I think for Puppet modules it can determine what kind of bump it needs to be based on the merged PRs and their labels. Any chance this could be generalized to gems using https://keepachangelog.com compatible changelogs?

@jordanbreen28
Copy link
Author

I think for Puppet modules it can determine what kind of bump it needs to be based on the merged PRs and their labels. Any chance this could be generalized to gems using https://keepachangelog.com compatible changelogs?

Thanks @ekohl - pdk is responsible for automatically updating the version number of our modules when running pdk release prep --force.

At the moment PDK isn't compatible with our tools/gems, but I do think that it would be worth exploring our options, and as you say generalise this, in the future :-)

@ekohl
Copy link

ekohl commented Mar 6, 2023

That would be great, because I can also see Vox Pupuli using it outside of the PDK. Do you happen to know which piece of code is responsible today?

@jordanbreen28
Copy link
Author

Apologies @ekohl - Looks like the code responsible in PDK can be found here, PDK seems to work with the github changelog generator in order to compute the next module version. Hope this helps :-)

@jordanbreen28 jordanbreen28 force-pushed the CONT-233-Add_version_input_gem_release branch from c3ff58a to 87ce022 Compare March 7, 2023 10:01
@ekohl
Copy link

ekohl commented Mar 7, 2023

Ah, that's much more low level than I thought. I personally had thought about parsing the Markdown and extracting headers. I suppose this also works. It's roughly the approach I had also thought of. I'd also see if I can pass an argument to the generator to mark next version as "Unreleased" instead of some version. That makes parsing a bit more reliable.

@chelnak chelnak merged commit 16a7d87 into main Mar 7, 2023
@chelnak chelnak deleted the CONT-233-Add_version_input_gem_release branch March 7, 2023 11:54
@jordanbreen28 jordanbreen28 added maintenance and removed feature New feature or request labels Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants