Skip to content

Conversation

@ekohl
Copy link
Contributor

@ekohl ekohl commented Apr 29, 2020

In Ruby 2.7 sending the last arguments as a hash leads to a deprecation warning. By accepting the keyword arguments, the methods are fully wrapped.

@DavidS
Copy link
Contributor

DavidS commented Apr 29, 2020

Thanks, Ewoud for this fix. I've addressed the rubocop issues in #13 , but trying to build a all-in-one integration branch in #14 showed some more issues. Please rebase this so we get a clean run.

@DavidS DavidS added the maintenance maintenance label Apr 29, 2020
@DavidS
Copy link
Contributor

DavidS commented Apr 29, 2020

Also, if you're already adding ruby 2.7 compatibility, please also add it to the travis matris (see b52709c )

ekohl added 3 commits April 29, 2020 16:43
In Ruby 2.7 sending the last arguments as a hash leads to a deprecation
warning. By accepting the keyword arguments, the methods are fully
wrapped.
@ekohl
Copy link
Contributor Author

ekohl commented Apr 29, 2020

Rebased. Technically the Gemfile change isn't needed, but I was in that file anyway to check.

@ekohl
Copy link
Contributor Author

ekohl commented Apr 29, 2020

Looks like this breaks on older Ruby versions. Rather than stubbing it here, have you considered a gem like fakefs or setting up temporary directories?

I'll also consider this lower priority. My other 2 PRs would be nice to get into a release.

@DavidS
Copy link
Contributor

DavidS commented Apr 29, 2020

I like the Gemfile change. The travis failure is now what I saw on #14 : seems like older rubies need a default value for kwargs?

@DavidS
Copy link
Contributor

DavidS commented Apr 30, 2020

I have no preference either way.

@ekohl
Copy link
Contributor Author

ekohl commented Apr 30, 2020

At this moment I have no time to finish this up due to other issues and it's not blocking me. I'll be happy if someone else picks this up, otherwise I'll get back to it once $work calms down again after the release.

@ekohl ekohl marked this pull request as draft April 30, 2020 12:53
@DavidS
Copy link
Contributor

DavidS commented May 5, 2020

@DavidS
Copy link
Contributor

DavidS commented Jun 8, 2020

Fixed this in #22

@DavidS DavidS closed this Jun 8, 2020
@ekohl ekohl deleted the ruby-2.7 branch June 8, 2020 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants