(maint) Various base maintenance adjustments

[DavidS]

No description provided.

[DavidS]

I didn't manage to get a remotely useful test pipeline up and running with ruby2.1 (see DavidS@4d43d19 for my last state before I gave up). So this only contains the lowering of the ruby lower bound.

[glennsarti]

Can't say I'm a fan of committing Gemfile.lock.

It causes problems in Cross Platform development e.g. on Windows.

PLATFORMS
  x64-mingw32

[DavidS]

Without it dependabot doesn't work. is this a case of either/or?

[glennsarti]

Given that the only thing that this gem will depend on is minitar and pathspec is dependabot even needed?

And it's causing complications with Travis testing as per your attempt at getting it run Ruby 2.1.9

[DavidS]

I gave this another go on my windows test VM. Adding the platform for windows didn't impact functionality on linux, even when installing gems with native binaries like puppet. so DavidS@eddc90e can go in with no bother.

When adding the rubocop changes (see DavidS@3e6ef8e) it breaks with

• if rubocop is installed: "Error: RuboCop found unsupported Ruby version 2.1 in TargetRubyVersion parameter (in .rubocop.yml). 2.1-compatible analysis was dropped after version 0.58."
• if rubocop is not installed: "LoadError: cannot load such file -- rubocop/rake_task"

both of which are not related to the lock file

[scotje]

Agree with @glennsarti about not including Gemfile.lock, it is considered a bad practice to version control Gemfile.lock in a gem that is intended to be composed into other projects. The runtime and development dependencies should be listed in the .gemspec unless that's not possible for some reason.

https://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/ (I know this is 10 years old at this point but I don't think the logic has fundamentally changed?)

[DavidS]

TIL: dependabot can update the gemspec: https://dependabot.com/ruby/; I'll get that fixed.

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@8450209). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #4   +/-   ##
=========================================
  Coverage          ?   71.79%           
=========================================
  Files             ?        2           
  Lines             ?      156           
  Branches          ?        0           
=========================================
  Hits              ?      112           
  Misses            ?       44           
  Partials          ?        0

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8450209...3e100b7. Read the comment docs.