(MAINT) Fix litmus testing #222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the litmus based testing is broken due to bugs in both Litmus and Bolt. This commit modifies the acceptance testing to: * Use a fixed fork of Litmus to enable the instal_modules_from_directory rake task * Monkey patches Bolt to be able to used due to Bolt Issue 1614 These parts can be reverted once their related PRs are merged and released.
glennsarti
force-pushed
the
fix-litmus
branch
from
6ac6ce3 to
3a45ca6
Compare
michaeltlombardi
approved these changes
Feb 20, 2020
Contributor
|
This seems like a sensible temporary workaround for litmus/bolt issues, is a blocker for the release, and only affects tests, so I'm going to merge given the normal maintainers are off-line and- this can be reverted if I'm out of bounds or when the fixes land for puppetlabs/puppet_litmus#248 and puppetlabs/bolt#1614. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the litmus based testing is broken due to bugs in both Litmus and
Bolt. This commit modifies the acceptance testing to:
task
These parts can be reverted once their related PRs are merged and released.