Using f12 / ctrl f12

[jgrammen-agilitypr]

Neither f12 nor ctrl f12 appear to work in visual studio code with the 0.7.1 version of the extension installed.
I cannot select a class (eg: users::my_name ) and press a key to go to the implementation/definition of that class. Should this work? maybe i am using the wrong shortcut?

[glennsarti]

Hi @jgrammen-agilitypr . The extension has never supported the peek definition feature. What I will do is add that as a feature request.

[jgrammen-agilitypr]

Hello, Thank you for the reply.
Ok, yes making it a feature request sounds about right.
It certainly would be very useful.
I currently use Geppetto and being able to jump to declaration / definition is something I use frequently.

[glennsarti]

Ahh ok. This may require some fiddling within Puppet to get that information but in theory it sounds like it's possible.

[jgrammen-agilitypr]

In case my feature request was not completely clear, hear are a few images:


When you click on the button it opens the file that defines Class mm::motd

[glennsarti]

Yup that's what I'm thinking of:

https://code.visualstudio.com/docs/editor/editingevolved#_go-to-definition

https://github.com/Microsoft/language-server-protocol/blob/master/protocol.md#goto-definition-request

[mdwheele]

@glennsarti, do you think this is something achievable without a ton of experience / intimate knowledge of VS Code extensions? I would be willing to make an attempt if you could point me in the right direction to get started.

[glennsarti]

Responding to requests from VScode and crafting the write JSON messages (as per language server protocol is easy enough).

The thing I don't know is;

Does puppet keep a track of which puppet classes were loaded from which file?
Does puppet keep track of which puppet functions were loaded from which file?
If that's stored somewhere then wiring that up isn't too hard.
If that's not stored that will require monkey patching the loaders in Puppet, and THAT is not a simple thing to do.