(maint) Use noop by default and fix readme typo #197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeltlombardi
suggested changes
Nov 21, 2017
client/README.md
Outdated
| **Note - This is an experimental feature** | ||
|
|
||
| The Puppet extension is able to debug the compilation of a Puppet manifest, much like a Go, PowerShell, C# etc. The debugger supports: | ||
| The Puppet extension is able to debug the compilation of a Puppet manifest, much like the Go, PowerShell and C# languages. The debugger supports: |
There was a problem hiding this comment.
You took away the oxford comma. 😞
There was a problem hiding this comment.
Oxford be damned!
Previously the debug server would default to applying changes to the system instead of being opt-in. This commit changes the deafault value of noop to true to make it safe by default. This commit also fixes typos in the README and credits Corey Osman with ideas behind the debug server.
glennsarti
force-pushed
the
add-debug-note
branch
from
1f0edcf to
874d9cd
Compare
|
@michaeltlombardi Ready for merge. |
jpogran
approved these changes
Nov 23, 2017
|
Addresses #100 as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the debug server would default to applying changes to the system
instead of being opt-in. This commit changes the deafault value of noop to true
to make it safe by default. This commit also fixes typos in the README and
credits Corey Osman with ideas behind the debug server.