Skip to content

Conversation

@jpogran
Copy link
Contributor

@jpogran jpogran commented Aug 20, 2019

This commit migrates the original test methods to the new vscode-test approach, as documented here: https://code.visualstudio.com/api/working-with-extensions/testing-extension#migrating-from-vscode

@jpogran jpogran requested a review from glennsarti as a code owner August 20, 2019 15:33
@jpogran jpogran self-assigned this Aug 20, 2019
@jpogran jpogran added this to the 0.20.0 milestone Aug 20, 2019
@jpogran jpogran force-pushed the maint-migrate-from-vscode-to-vscode-test branch 3 times, most recently from 3338d60 to 43cac2a Compare August 20, 2019 15:56
This commit migrates the original test methods to the new vscode-test
approach, as documented here: https://code.visualstudio.com/api/working-with-extensions/testing-extension#migrating-from-vscode
@jpogran jpogran force-pushed the maint-migrate-from-vscode-to-vscode-test branch from 43cac2a to c29eb13 Compare August 20, 2019 16:05
@glennsarti
Copy link
Contributor

  • can run npm run test
  • can run the extension via

Copy link
Contributor

@glennsarti glennsarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@glennsarti glennsarti merged commit 17f3662 into puppetlabs:master Aug 21, 2019
@jpogran jpogran deleted the maint-migrate-from-vscode-to-vscode-test branch June 7, 2021 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants