(maint) Update telemetry to v0.1.2 #584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit udpates the telemetry package to 0.1.2 as well as adding the exception method to the reporter class.
glennsarti
reviewed
Nov 14, 2019
| properties?: { [key: string]: string }, | ||
| measures?: { [key: string]: number } | ||
| ): void; | ||
| sendTelemetryException( |
There was a problem hiding this comment.
Huh. You woulda thought the telemetry module would have the needed typings.
There was a problem hiding this comment.
This is a result of using a wrapper class. Once we move it to it's own object we won't have to do this
glennsarti
approved these changes
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit udpates the telemetry package to 0.1.2 as well as adding the
exception method to the reporter class.