(maint) Remove TelemetryReporter Wrapper #587
Merged
+37
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpogran
force-pushed
the
maint-remove-telemetry-class-wrapper
branch
from
c079484 to
8a3848a
Compare
jpogran
force-pushed
the
maint-remove-telemetry-class-wrapper
branch
2 times, most recently
from
391fef2 to
ed2ecaa
Compare
This commit removes the TelemetryReporter wrapper class and type files and global export in favor of a variable passed down through class constructors.
jpogran
force-pushed
the
maint-remove-telemetry-class-wrapper
branch
from
ed2ecaa to
68d2196
Compare
|
Going to test this with real data, but otherwise I think its at the point I want it |
|
Confirmed works without error in portal |
glennsarti
approved these changes
Nov 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the TelemetryReporter wrapper class and type files
and global export in favor of a variable passed down through class
constructors.