(maint) Alert if jpogran.puppet-vscode installed #628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpogran
force-pushed
the
maint-alert-if-jpogran-extension-installed
branch
from
21fdafc to
3e3cd35
Compare
glennsarti
reviewed
Apr 22, 2020
src/extension.ts
Outdated
| export function activate(context: vscode.ExtensionContext) { | ||
| let pkg = vscode.extensions.getExtension('jpogran.puppet-vscode'); | ||
| if (pkg){ | ||
| let message = 'The "jpogran.puppet-vscode" extension has been detected. Please uninstall it by executing the following from the commandline: "code --uninstall-extension jpogran.puppet-vscode"'; |
There was a problem hiding this comment.
Is it worth mentioning why this is bad?
There was a problem hiding this comment.
Suggested change
| let message = 'The "jpogran.puppet-vscode" extension has been detected. Please uninstall it by executing the following from the commandline: "code --uninstall-extension jpogran.puppet-vscode"'; | |
| let message = 'The "jpogran.puppet-vscode" extension has been detected. Is not maintained anymore. To uninstall it, execute the following from the commandline: "code --uninstall-extension jpogran.puppet-vscode"'; |
?
There was a problem hiding this comment.
I think Glenn meant the kind of detail I put in the commit message could be useful to tell the user. It's less important that its unmaintained compared to the race condition that will cause errors.
There was a problem hiding this comment.
the fact that I missed it in the commit message seems to indicate that glenn is right :-D
This commit adds a warning if the `jpogran.puppet-vscode` extension is installed while the `puppet.puppet-vscode` extension is. This can cause a race condition where each extension tries to register at the same time, which will produce error message popups.
jpogran
force-pushed
the
maint-alert-if-jpogran-extension-installed
branch
from
3e3cd35 to
ef7a1e5
Compare
glennsarti
approved these changes
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a warning if the
jpogran.puppet-vscodeextension isinstalled while the
puppet.puppet-vscodeextension is. This can causea race condition where each extension tries to register at the same
time, which will produce error message popups.