(GH-642) Migrate to ES Lint #662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the viz.js dependency that was missed in puppetlabs#613.
jpogran
force-pushed
the
gh-642-eslint-migration
branch
4 times, most recently
from
1d3e4b8 to
6083377
Compare
jpogran
force-pushed
the
gh-642-eslint-migration
branch
2 times, most recently
from
d016027 to
22f8dcd
Compare
This commit adds and configures eslint to work with prettier in this project.
Apply all eslint automated fixes using existing rulesets.
Address reported errors from existing eslint rulesets.
jpogran
force-pushed
the
gh-642-eslint-migration
branch
from
22f8dcd to
2f15f1f
Compare
glennsarti
approved these changes
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restricted this PR to only changes needed to add and configure eslint, and putting the other npm package updates into a separate PR.
All fixes are either simple automatic fixes or only those that do not change location of methods or function