(#7986) make solaris pkg versionable.#1046
Merged
joshcooper merged 2 commits intopuppetlabs:3.xfrom Aug 23, 2012
vrthra:ticket/3.x/11004_pkg_provider
Merged
(#7986) make solaris pkg versionable.#1046joshcooper merged 2 commits intopuppetlabs:3.xfrom vrthra:ticket/3.x/11004_pkg_provider
joshcooper merged 2 commits intopuppetlabs:3.xfrom
vrthra:ticket/3.x/11004_pkg_provider
Conversation
Contributor
Author
|
@joshcooper updated the execution & tests. |
lib/puppet/provider/package/pkg.rb
Outdated
Contributor
There was a problem hiding this comment.
@vrthra It seems problematic to do this each time such as if puppet is installing multiple packages. Each pkg refresh invocation will cause the system to refresh catalogs from all publishers in the image. Are there typically many publishers? I would imagine a sysadmin would configure their systems to refresh catalogs periodically, e.g. once per day, using some other mechanism, e.g. exec resource with a schedule. But perhaps not? I don't know. Can you check with Ben and Stefan about this? I'd be keen to get their perspective
Contributor
Author
|
@joshcooper fixed test failures. |
Changes: * Add :versionable and :upgradable to features ** Ensurable now returns version rather than present/absent * Enable :defaultfor solaris 5.11 * Change update to use pkg update, and ensure that we ignore return 4 * Update the test cases to reflect these.
Modified pkg_spec test case to verify that pkg is the default provider for opensolaris
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
** Ensurable now returns version rather than present/absent