#15959: groupadd system parameter is not supported on solaris#1052
Conversation
Tests are now ordered by method, so if modifications have to be done done in the provider code, it will be easier to track the according spec tests that have to be changed.
It seams to be more reliable to work with real objects instead
According to http://docs.oracle.com/cd/E19963-01/html/821-1462/useradd-1m.html http://nixdoc.net/man-pages/hp-ux/man1/useradd.1m.html neither Solaris nor HP-UX support the -r switch to create system users so the useradd provider should not claim to support system_users on these platforms.
Tests are now ordered by method, so if modifications have to be done done in the provider code, it will be easier to track the according spec tests that have to be changed.
It seams to be more reliable to work with real objects instead
According to http://nixdoc.net/man-pages/hp-ux/man1/groupadd.1m.html http://docs.oracle.com/cd/E19963-01/html/821-1462/groupadd-1m.html neither Solaris nor HP-UX support the -r switch to create system groups so the groupadd provider should not claim to support system_groups on these platforms.
|
If you think this change should go in 3.x or master rather then 2.7.x please tell me so I can rebase. |
|
your commits seems have the same messages (5e64 -> 6350) (e111 -> c50f5) (03c7-> c404), is that intensional? |
|
@vrthra i first modified the useradd provider (e111f56, 03c7ddf, 5e64c1f) and then I noticed that the same task has to be done for the groupadd provider (rearrange tests, use real objects in the specs, remove the |
|
Oh sorry, didn't notice useradd/groupadd. |
|
@stschulte , I think this should be targeted to 3.x (as you noted in your comment.) |
|
I get 17 test failures running this on the Mac, which I will add to the ticket. I will try and find some time to look into them if you can't, but I don't think that will be for a week or more. |
|
This should, however, target 2.7.x as noted - it is pretty clearly a bug fix worth shipping in the stable release. |
|
@daniel-pittman The specs should now always pick the useradd/groupadd provider. Please let me know if the specs are still failing. |
The groupadd and useradd spec will only work if groupadd / useradd are the default provider for the group / user type. Explicitly set the provider in the spec tests so they can e.g. also run on MacOSX.
|
@daniel-pittman The specs should now always pick the useradd/groupadd provider. Please let me know if the specs are still failing. |
…emparam #15959: groupadd system parameter is not supported on solaris
3 participants
On Solaris and HP-UX the groupadd and useradd commands to not support the
-rswitch to create systemusers and systemgroups.Do not claim to support feature
system_usersandsystem_groupson Solaris and HP-UX.