Maint/2.7.x/9186 fix shared examples#114
Merged
nicklewis merged 2 commits intopuppetlabs:2.7.xfrom Sep 14, 2011
Merged
Conversation
The build broke because I was using "shared_examples" which is not available in older rspec versions, e.g. 2.3.0 (which is what our windows jenkins nodes are configured with). Just changed the spec test to use "shared_examples_for" instead.
The Sys::Admin.get_user method doesn't work when the username exists in the WMI Win32_Account class, but not the Win32_UserAccount class. For example, SYSTEM which is the user context under which the jenkins agent runs under. This commit modifies the spec test to query the more general Win32_Account class. This code will be moved to a more generic location in a future commit.
hlindberg
pushed a commit
to hlindberg/puppet
that referenced
this pull request
Oct 16, 2014
fixed unused variable in First Function example
melissa
pushed a commit
to melissa/puppet
that referenced
this pull request
Mar 30, 2018
(maint) Fix results dir and modules config suffix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix failing tests due to older rspec and running under the SYSTEM account.