(#15717) Restore puppet kick functionality#1200
Merged
joshcooper merged 2 commits intopuppetlabs:3.0.xfrom Oct 4, 2012
Merged
Conversation
Commit 81c73fd had accidentally removed any requires of the `puppet/run` file and so the code needed for kick was not being loaded. This adds loading of that file back into the agent application.
Commit 62420c6 changed the way that agents decided to perform a pluginsync to have a flag passed in. The initialize method of Puppet::Run tries to validate the options passed in and failed when it recieved the new option. This makes the new option validate and restores the ability to use puppet kick.
Contributor
|
+1 I tested locally and it works here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The puppet kick functionality in 3.0.0 had been broken in two ways:
puppet/runfile loaded:pluginsyncoption during initializationThis pull request fixes both of those problems and allows
puppet kickto workagain, but leaves it deprecated