Skip to content

Resolve #11042#1230

Closed
nhemingway wants to merge 3 commits intopuppetlabs:masterfrom
nhemingway:master
Closed

Resolve #11042#1230
nhemingway wants to merge 3 commits intopuppetlabs:masterfrom
nhemingway:master

Conversation

@nhemingway
Copy link

Convert group names to numbers when creating users with the ldap provider.

If we don't do this, then 389 balks with a "Invalid Syntax" error.

@jeffmccune
Copy link
Contributor

@nhemingway This looks like a good start. I can't merge this as is though mainly do to housekeeping concerns.

The two merge commits included in this change set should not be merged into the mainline, and they will as the change set currently stand.

Could you rebase this topic branch against the upstream topic branch? The following commands should help do this:

git branch fix/master/11042_ldap_provider_group_names master
git fetch origin
git checkout master
git reset --hard origin/master
git checkout fix/master/11042_ldap_provider_group_names
git rebase origin/master

Once you've done this, please submit a new pull request from your fix/master/11042_ldap_provider_group_names topic branch instead of your master branch. This will help us keep the history nice and clean.

-Jeff

@jeffmccune
Copy link
Contributor

I'm going to go a head and close this pull request, please re-open a new one from the topic branch. If you have any questions or concerns please hit me up on IRC, email, or Twitter.

-Jeff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants