(#18047) Revert change to user confdir#1324
Merged
zaphod42 merged 1 commit intopuppetlabs:3.0.xfrom Dec 11, 2012
Merged
Conversation
In 3.0, the default user confdir (and vardir) was changed from ~/.puppet to the Dir::LOCAL_APPDATA/PuppetLabs. However, when puppet is run as a non-administrator, puppet will attempt to create its confdir, e.g. C:\Users\albert\AppData\Local\PuppetLabs\puppet, and fail because the parent PuppetLabs directory doesn't exist. This wasn't an issue in 2.7.x, because the confdir was ~/.puppet, so the parent directory always existed. This commit restores the previous behavior for non-administrators. No changes are required for administrators, because the MSI installer creates the necessary directories within COMMON_APPDATA.
zaphod42
added a commit
that referenced
this pull request
Dec 11, 2012
…er-confdir (#18047) Revert change to user confdir
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 3.0, the default user confdir (and vardir) was changed from ~/.puppet
to the Dir::LOCAL_APPDATA/PuppetLabs. However, when puppet is run as a
non-administrator, puppet will attempt to create its confdir, e.g.
C:\Users\albert\AppData\Local\PuppetLabs\puppet, and fail because the
parent PuppetLabs directory doesn't exist.
This wasn't an issue in 2.7.x, because the confdir was ~/.puppet, so the
parent directory always existed.
This commit restores the previous behavior for non-administrators. No
changes are required for administrators, because the MSI installer creates
the necessary directories within COMMON_APPDATA.