(#18121) Collector overrides should work in Ruby 1.9#1333
Closed
hunner wants to merge 1 commit intopuppetlabs:masterfrom
Closed
(#18121) Collector overrides should work in Ruby 1.9#1333hunner wants to merge 1 commit intopuppetlabs:masterfrom
hunner wants to merge 1 commit intopuppetlabs:masterfrom
Conversation
Increase arity of child_of? meta_def to 1 child_of? defined for Puppet::Resource::Type objects has an arity of 1, but the meta_def of the same function created by Puppet::Parser::Collector objects has an arity of 0. This throws errors when the meta_def method is called with arguments. This commit matches the arity so that this error will not be present.
Contributor
|
@hunner do you have a simple test case that can reproduce the problem? I can put it together as an automated test if you can just let me know a simple way of doing it. |
Contributor
|
@hunner never mind. I see that you give one in the referenced bug. Thanks! |
Contributor
|
Fixed up an re-opened as PR #1334 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increase arity of child_of? meta_def to 1
child_of? defined for Puppet::Resource::Type objects has an arity of 1,
but the meta_def of the same function created by
Puppet::Parser::Collector objects has an arity of 0. This throws errors
when the meta_def method is called with arguments. This commit matches
the arity so that this error will not be present.