Maint: Remove dead ca_md setting#1390
Merged
zaphod42 merged 1 commit intopuppetlabs:masterfrom Jan 15, 2013
Merged
Conversation
The `ca_md` setting was added in commit bb4b5a5 in Aug 2005, but was never used in that commit or any subsequent commit. The setting itself is also confusing, because we create digital signatures on both the agent (when signing the CSR) and the CA (when signing the x509 cert). It's also confusing because both encryption and hash algorithms need to be specified when creating a digital signature, e.g. sha256WithRSAEncryption. But the existence of the `ca_md` property might encourage patches to allow the hash algorithm to be configured, but not the encryption algorithm. Long term, we'd like to eliminate hard coding of cryptographic parameters, as it makes it difficult to upgrade while maintaining compatibility across different versions of master and agents.
zaphod42
added a commit
that referenced
this pull request
Jan 15, 2013
…tting Maint: Remove dead ca_md setting
paravoid
pushed a commit
to wikimedia/operations-puppet
that referenced
this pull request
Jun 22, 2015
This setting never had any effect, and has been removed upstream: puppetlabs/puppet#1390 Change-Id: If95dfce645d9ab0bf28adb4fea946995623e69fe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ca_mdsetting was added in commit bb4b5a5 in Aug 2005, but wasnever used in that commit or any subsequent commit.
The setting itself is also confusing, because we create digital
signatures on both the agent (when signing the CSR) and the CA (when
signing the x509 cert).
It's also confusing because both encryption and hash algorithms need to
be specified when creating a digital signature, e.g.
sha256WithRSAEncryption. But the existence of the
ca_mdproperty mightencourage patches to allow the hash algorithm to be configured, but not
the encryption algorithm.
Long term, we'd like to eliminate hard coding of cryptographic
parameters, as it makes it difficult to upgrade while maintaining
compatibility across different versions of master and agents.