Add deprecation warning for use of ruby dsl.#1427
Merged
zaphod42 merged 1 commit intopuppetlabs:masterfrom Jan 25, 2013
Merged
Conversation
This adds a deprecation warning for parsing of ruby based manifests. Tests are updated to check that the deprecation warning is issued for ruby manifest, but not otherwise.
zaphod42
added a commit
that referenced
this pull request
Jan 25, 2013
Add deprecation warning for use of ruby dsl.
zaphod42
added a commit
to zaphod42/puppet
that referenced
this pull request
May 28, 2013
Add deprecation warning for use of ruby dsl.
ffrank
added a commit
to ffrank/puppet
that referenced
this pull request
Dec 1, 2013
The fix for puppetlabs#1427 added an instance method to the scope class for exporting all variables from the local scope. This method apparently re-implemented the dynamic scoping rules. When those were removed, the #to_hash method was left as was. As a result, dynamic scoping still worked from within templates, when using the @variable syntax in the erb code. Fix this by using the new #enclosing_scope method so that proper scoping rules are used instead.
ffrank
added a commit
to ffrank/puppet
that referenced
this pull request
Dec 27, 2013
The fix for puppetlabs#1427 added an instance method to the scope class for exporting all variables from the local scope. This method apparently re-implemented the dynamic scoping rules. When those were removed, the #to_hash method was left as was. As a result, dynamic scoping still worked from within templates, when using the @variable syntax in the erb code. Fix this by using the new #enclosing_scope method so that proper scoping rules are used instead.
ffrank
added a commit
to ffrank/puppet
that referenced
this pull request
Feb 13, 2014
The fix for puppetlabs#1427 added an instance method to the scope class for exporting all variables from the local scope. This method apparently re-implemented the dynamic scoping rules. When those were removed, the #to_hash method was left as was. As a result, dynamic scoping still worked from within templates, when using the @variable syntax in the erb code. Fix this by using the new #enclosing_scope method so that proper scoping rules are used instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a deprecation warning for parsing of ruby based manifests.
Tests are updated to check that the deprecation warning is issued.