Conversation
|
The % modulo operator is backwards compatible as it is not a special token in any way and could never have been included in any legal construct other than quoted strings. (See my other comments about adding the keyword "xor" and its implementation). |
|
@dalen it looks like this will need a rebase since GH-1436 has been reverted. Do you mind basing this off master? Other than the rebase, I don't see any reason not to merge this in. @hlindberg please let me know if I misunderstand your comment, but my interpretation is that you don't have any concerns that need to be addressed before we merge this in. |
|
I have rebased it, but for some reason github isn't updating the pull request. I can create a new one though. |
The modulo arithmetic operator.
|
okay, got it to update the pull request now. |
|
Merged into master as d038b2a. This should be released in 3.2.0. Thanks again for the contribution! -Jeff |
|
I was just about to post that I meant that it looked ok. When I posted earlier I had only looked at a couple of things. But now I have read it again in detail. So yeah, good contribution and thank you. |
3 participants
This adds the modulo operator.
Done on top of the #1436 pull request to not collide with it.