(#17474) Make it possible to return false from a terminus#1451
Merged
joshcooper merged 1 commit intopuppetlabs:masterfrom Feb 9, 2013
Merged
(#17474) Make it possible to return false from a terminus#1451joshcooper merged 1 commit intopuppetlabs:masterfrom
false from a terminus#1451joshcooper merged 1 commit intopuppetlabs:masterfrom
Conversation
This manifested as an inability to retrieve the value `false` from hiera using data bindings. The find method on Puppet::Indirection interpreted this as no value being returned.
Contributor
There was a problem hiding this comment.
@pcarlisle why do we go through the process of preparing the request and looking in the cache, only then to check if the request ignores the terminus? Seems like that could be moved much earlier, but of course, there are probably side-effects that would prevent us from doing that.
Contributor
Author
There was a problem hiding this comment.
I don't know, I just preserved the preexisting logic. It seemed like it would be a behavior change.
|
I'm using puppet version 3.8.1 and hiera 1.3.4 and still seeing the same issue as mentioned in Bug#17474. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This manifested as an inability to retrieve the value
falsefrom hiera usingdata bindings. The find method on Puppet::Indirection interpreted this as no
value being returned.