(#14544) The apply application should support writing the resources file...#1465
(#14544) The apply application should support writing the resources file...#1465ripienaar wants to merge 1 commit intopuppetlabs:masterfrom ripienaar:feature/master/14544
Conversation
…ile and classes file MCollective requires a classes.txt and resources.txt to function. The agent application writes this by default but the apply application has no way to write these files. With the increased popularity of running puppet masterless opting instead to only run puppet apply on every node this is becoming a problem for mcollective users who wish to run this mode of puppet configuration management This commits adds a new flag to the apply application - --write-catalog-summary - which enables the creation of these 2 files leaving it off by default to avoid apply from stepping on the toes of an agent unless the user specifically request this behavior
|
Note I have no idea if this command line argument name is a good choice, happy to change it to whatever works for you based on feedback here |
|
Thank you for contributing to Puppet! This change will really improve the experience for people running masterless Puppet and MCollective. Thanks for adding it. Everything looks great, and I think the command line argument is fine as it is. My only rather nitpicky comment is that the first line of the commit message should be imperative. I know it's minor, but it really helps me scan the shortlog in a smooth manner. I've amended the commit to be, "(#14544) Make puppet apply --write-catalog-summary produce resources and classes state files" The rest of the commit message is great, it gave me a clear understanding of why this change is important. |
|
Merged into master as 7babca1. This should be released in Puppet 3.2. Thanks again for the contribution! -Jeff |
... and classes file
MCollective requires a classes.txt and resources.txt to function. The
agent application writes this by default but the apply application has
no way to write these files.
With the increased popularity of running puppet masterless opting
instead to only run puppet apply on every node this is becoming a
problem for mcollective users who wish to run this mode of puppet
configuration management
This commits adds a new flag to the apply application -
--write-catalog-summary - which enables the creation of these 2 files
leaving it off by default to avoid apply from stepping on the toes of an
agent unless the user specifically request this behavior