(#19713) Validate exec commands to be type String#1525
Merged
adrienthebo merged 2 commits intopuppetlabs:masterfrom Mar 13, 2013
Merged
(#19713) Validate exec commands to be type String#1525adrienthebo merged 2 commits intopuppetlabs:masterfrom
adrienthebo merged 2 commits intopuppetlabs:masterfrom
Conversation
Add tests that ensure `exec` resources raise errors if the value given for `command` is not of type `String`.
The `exec` type calls a pile of string-specific methods, such as `scan` and `split`, on the value of `command`. Validate that `command` is of type `String` so that Puppet can fail with a helpful message if the value was passed as a type such as `Array`.
adrienthebo
added a commit
that referenced
this pull request
Mar 13, 2013
…ings (#19713) Validate exec commands to be type String
Contributor
|
Merged into master as d3cd851. This should be released in 3.2.0. Thanks again for the contribution! -Adrien |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
exectype calls a pile of string-specific methods, such asscanandsplit, on the value ofcommand. Validate thatcommandis of typeStringso that Puppet can fail with a helpful message if the value was passed as a
type such as
Array.