(maint) Handle different ssh service names in puppet resource service test#1620
Closed
nicklewis wants to merge 2 commits intopuppetlabs:masterfrom
Closed
(maint) Handle different ssh service names in puppet resource service test#1620nicklewis wants to merge 2 commits intopuppetlabs:masterfrom
puppet resource service test#1620nicklewis wants to merge 2 commits intopuppetlabs:masterfrom
Conversation
|
CLA Signed by nicklewis on 2010-08-23 21:00:00 -0700 |
Contributor
|
Ah, so I'm having difficulty rebasing this onto Thanks, |
This reverts commit dd4d41e.
…e` test This test was using a regex to match the output for the ssh/sshd service from puppet resource, but was explicitly invoking the command with the name ssh. Since we can check the state of that service from the list of all instances (in which case the regex is actually beneficial), there's no need to look at the specific service separately. This combines the two steps, and makes the test more robust to different names for the ssh service.
Contributor
Author
|
Reverted the revert and rebased off that. Should work now. |
Contributor
|
summary: Merged into stable and master as d4ced36. This should be released in Puppet 3.2. Thanks again for the contribution! This fix resolves the issue where by puppet runs dangerous init scripts on Debian which affect the system while checking the state of the system. -Jeff |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test was using a regex to match the output for the ssh/sshd service
from puppet resource, but was explicitly invoking the command with the
name ssh. Since we can check the state of that service from the list of
all instances (in which case the regex is actually beneficial), there's
no need to look at the specific service separately. This combines the
two steps, and makes the test more robust to different names for the ssh
service.