Closed
Conversation
If we specify array_matching => all for a property and the should value
is an empty array I would expect that puppet removes any possible is
value instead of ignoring the property entirely. Example taken from
issue #10237:
k5login {'/root/.k5login':
principals => []
}
With this patch applied we do not ignore the principals property.
Instead we do remove any principal that is mentioned in
`/root/.k5login` (in my opinion the expected behaviour).
This change effects other types that use :array_matching => all
as well and is potentially dangerous if we have a default value
of [] somewhere. But that does not seem to be the case.
Contributor
|
I would also expect the behavior to be to remove any principal mentioned, but it doesn't seem like a change that should be made in a point release. I'd be a lot more comfortable if it were changed to warn in 2.7.x and moved to the new behavior in a future version, especially since this affects all types with |
Contributor
|
I think that this should be targeted no sooner than master (for release in Telly). This is a very big change in behavior to how arrays are handled for properties/parameters. I'm closing this so it can be re-targeted at master. |
hlindberg
pushed a commit
to hlindberg/puppet
that referenced
this pull request
Oct 16, 2014
…rements (#21029) 3.x masters require OpenSSL 0.9.8o+
melissa
pushed a commit
to melissa/puppet
that referenced
this pull request
Mar 30, 2018
(PCP-113) Failed puppet run should return more information
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we specify array_matching => all for a property and the should value
is an empty array I would expect that puppet removes any possible is
value instead of ignoring the property entirely. Example taken from
issue #10237:
With this patch applied we do not ignore the principals property.
Instead we do remove any principal that is mentioned in
/root/.k5login(in my opinion the expected behaviour).This change effects other types that use :array_matching => all
as well and is potentially dangerous if we have a default value
of [] somewhere. But that does not seem to be the case.