(#21709) Master no longer logs catalog compilation time#1759
(#21709) Master no longer logs catalog compilation time#1759adrienthebo merged 1 commit intopuppetlabs:masterfrom
Conversation
Discussed with jamesturnbull to submit this as a workaround.
|
CLA signed by all contributors. |
|
Thank you very much for this contribution! This seems like a reasonable fix, but I'm concerned about the risk of regression. Do you think we need tests for this behavior or is this a small enough change to merge as-is? |
|
To restore old behavior I think it's okay. I wouldn't be too worried about regression on this one, the benchmark block was there a long time before. The only regression I can think of is that the the two blocks inside each other could give problems. I don't have much experience with this yet so I'll leave it up to you. |
|
@superseb with something like this it's hard to test without writing an acceptance test or writing a test that only checks the implementation, so it's a messy situation. As you made the comment is that it's been there a long time, and it doesn't pose a major risk of there's a regression so I'll merge this as-is. As a heads up we have some spurious failures in CI, so there's a chance you might get an email about a failing build after I merge this. If you do don't worry, we'll handle any sort of errors on our end. |
(#21709) Master no longer logs catalog compilation time
|
summary: merged into master in 4f22d30; this should be released in 3.3.0. Thanks again for the contribution! |
3 participants
Discussed with jamesturnbull to submit this as a workaround.