(#22079) Fix HashArrayAccess produces :undef when value is false#1825
Merged
jpartlow merged 1 commit intopuppetlabs:masterfrom Aug 5, 2013
Merged
Conversation
It should naturally have produced false. The test for "having value" was wrong and equated nil with false.
jpartlow
added a commit
that referenced
this pull request
Aug 5, 2013
…ray-access (#22079) Fix HashArrayAccess produces :undef when value is false
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It should naturally have produced false. The test for "having value" was
wrong and equated nil with false.