(#22608) Accept pson file backups#1919
Merged
jpartlow merged 1 commit intopuppetlabs:stablefrom Sep 19, 2013
Merged
Conversation
|
CLA signed by all contributors. |
spec/unit/file_bucket/file_spec.rb
Outdated
Contributor
There was a problem hiding this comment.
@joshcooper I read the comment below, and I think I understand how pson is broken, but I'm confused by the pending message. When would this test pass if pson is deprecated and slated for removal?
Contributor
Author
There was a problem hiding this comment.
@jpartlow I wanted to ensure we had a test that pson round-tripping is broken, but now that I think about it, I removed the to_pson method earlier (because we never want the agent to send it as pson), then the master needs to be prepared to accept it. Let me rework this PR.
Commit 769dcdf for #22375 removed the ability for newer masters to accept pson encoded file backups from older agents. This commit ensures that masters can deserialize `s` or `pson` encoded file backups, while agents will serialize using `s` by default. It also restores the ability to serialize to pson, but adds a deprecation warning if that happens. Since pson is not the `default_format` the agent will never serialize file bucket files to pson.
jpartlow
added a commit
that referenced
this pull request
Sep 19, 2013
…son-file-backups (#22608) Accept pson file backups
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 769dcdf for #22375 removed the ability for newer masters to accept pson encoded file backups from older agents.
This commit ensures that masters can deserialize
sorpsonencoded file backups, while agents will serialize usingsby default.