Issues 22646, 22647, 22648 data-in-modules simplification#1957
Closed
hlindberg wants to merge 7 commits intopuppetlabs:masterfrom
Closed
Issues 22646, 22647, 22648 data-in-modules simplification#1957hlindberg wants to merge 7 commits intopuppetlabs:masterfrom
hlindberg wants to merge 7 commits intopuppetlabs:masterfrom
Conversation
This adds the basic attributes and defaults to the Hiera2::Config class to support the simpler configuration described in issue 22646).
This modifies the hiera2 config checker to use a specific checker for version 2 and 3. The config selects the checker. Testfixtures moved to version 2 specific folder. Tests updated to load from the version 2 fixtures, and also expect there to be a deprecation warning. Tests for version 3 remains to be written.
This adds testing of hiera-2 hiera.yaml using version 3. It also adds the issues introduced by the version 3 checker, and corrects several issues in the checker implementation. Fixture data reorganized (remove one level in the directory structure and making it easier to remove support for version 2 data in the future.
This adds fixtures and more tests for hiera.yaml format 3. - simple, same format as hiera1 - complex, more than one category, more than one path
This tests a hiera.yaml configuration that uses all defaults expect category.
This commit makes it possible to specify the categories in
the binder_config.yaml using one of:
* a string (the category name, the value becomes '$name')
* an array [name, value]
* an object { name: 'name', value: 'value'}
If the value part is missing it automatically becomes '$name'.
Since a path, or paths may be located in a different location than the common datadir that applies to all paths it is now possible to set datadir for one entry in the hierarchy. This overrides the datadir set at the top level.
|
CLA signed by all contributors. |
Contributor
|
Since we are not going to be moving forward with this implementation, these changes aren't needed anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This contains fixes for Redmine issues 22646, 22647, 22648
The boundaries between the issues somewhat blurred, all commits marked with 22646.
Overview of what the simplifications are is found here: https://github.com/hlindberg/misc-puppet-docs/blob/master/improvements-arm-9.md