(#22792) rename 'select' to 'filter'#1988
Merged
joshcooper merged 5 commits intopuppetlabs:masterfrom Oct 14, 2013
Merged
Conversation
This adds a select function that tells user to update their manifests to use the filter function. The function is reserved for future use.
|
CLA signed by all contributors. |
Contributor
Author
There was a problem hiding this comment.
yep, typo :-( fixing
Contributor
Author
|
All previous comments addressed. And yeah, Ruby - sometimes it is like hacking onions... |
Contributor
|
Merged in ca454e1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This renames 'select' to 'filter' and adds a 'select' function that tells the user the function has been renamed.
It also documents that 'select' is reserved for future use.