(#21874) Make name[x] different from name [x]#2020
Closed
hlindberg wants to merge 1 commit intopuppetlabs:masterfrom
Closed
(#21874) Make name[x] different from name [x]#2020hlindberg wants to merge 1 commit intopuppetlabs:masterfrom
hlindberg wants to merge 1 commit intopuppetlabs:masterfrom
Conversation
|
CLA signed by all contributors. |
Contributor
|
@hlindberg I think this is liked to the wrong redmine issue. Can you double check that? |
Contributor
|
Need some tests |
Contributor
Author
|
Doh, off by one error, it is #21874 |
Contributor
Author
|
Tests added |
The parser cannot differentiate between a call of function 'name' with array as argument from deprecated resource reference (e.g. file['foo']) since whitespace is not significant. This is fixed by letting the lexer generate a separate token for a LBRACK when it is preceded by a NAME and WS.
Contributor
Author
|
Doh, and it failed on 1.8.7 string[] returning int as well. Updated. |
Contributor
Author
|
This PR is only meaningful in a 3.4.x release now that work has progressed on the future evaluator for 3.5 where the behavior is already implemented. Keeping this open if there is the desire to include this, but then retargeted for stable and a maintenance release of 3.4 |
Contributor
Author
|
Closing. This is fixed in the future parser/evaluator that is in master already. Not retargeting for maintenance release of Puppet 3.4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parser cannot differentiate between a call of function 'name' with
array as argument from deprecated resource reference (e.g. file['foo'])
since whitespace is not significant.
This is fixed by letting the lexer generate a separate token for a
LBRACK when it is preceded by a NAME and WS.