(#23126) Allow facter and hiera gem locations to be SSH git URLs#2054
Merged
kylog merged 1 commit intopuppetlabs:stablefrom Nov 13, 2013
Merged
(#23126) Allow facter and hiera gem locations to be SSH git URLs#2054kylog merged 1 commit intopuppetlabs:stablefrom
kylog merged 1 commit intopuppetlabs:stablefrom
Conversation
Previously, git urls could only be specified as `git://`. This works fine for pulling down the puppetlabs facter and hiera repos, but doesn't allow private forks of those to be pulled down. This is problematic because the Gemfile is used for setting up our test environments and the PE versions of facter and hiera are accessed over SSH. This commit allows git@ urls in addition to the curreng git: urls.
|
CLA signed by all contributors. |
kylog
pushed a commit
that referenced
this pull request
Nov 13, 2013
(#23126) Allow facter and hiera gem locations to be SSH git URLs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, git urls could only be specified as
git://. This worksfine for pulling down the puppetlabs facter and hiera repos, but
doesn't allow private forks of those to be pulled down. This is
problematic because the Gemfile is used for setting up our test
environments and the PE versions of facter and hiera are accessed over
SSH.
This commit allows git@ urls in addition to the current git: urls.