(#23141) Rework 'remounts' for BSDs

[jasperla]

This also implements using the equivalent operation on the various BSD(-derived) systems, except for AIX.

[jasperla]

The first Travis failure is fixed with the updated test in 87b7299, however I could use some help in understanding the failure of spec/integration/provider/mount_spec.rb...

[puppetcla]

CLA signed by all contributors.

[jhoblitt]

Are the semantics of update here the same as the remount option with mount from util-linux?

[jasperla]

Yes, you can pass options after 'update' like you would on Linux, like 'mount -o update,ro' behaves as one would expect it to, to mount the filesystem read-only.

[kylog]

I understand why the integration tests are failing and have a prospective fix here:

https://github.com/kylog/puppet/tree/issue/23141/mount-update-on-bsd

Can you test it out?

Basically, I'm clear on the part about why the integration tests are failing and how to approach fixing them, but I'm less clear on whether my change to mount.rb is called for (append 'update' to options, rather than override), b/c I'm not familiar with the nuances of bsd mount in the mount provider. So please comment.

[jasperla]

Thanks @kylog , I can confirm this patch works OK on OpenBSD.

[kylog]

@jasperla My original branch introduced some add'l spec failures, so I updated it to fix those: pull #2140.

Did you try this on OSX? I did and I ran into difficulties, so in my update I dropped Darwin from the list that uses the new update option (i.e. it turns this into no-change for Darwin). If you did try this on OSX, I'd like to compare notes so I can spot-check it locally.

Also, I'm closing this pull. We can carry on discussion on #2140 (or irc). Thx.