Feature/23201/csr extension requests#2091
Merged
jpartlow merged 6 commits intopuppetlabs:masterfrom Nov 19, 2013
Merged
Conversation
Puppet has never provided a way to add microsoft extension requests to generated CSRs, so it's not something we would necessarily restore. This commit removes a comment that indicates that we used to support msExtReq.
The `Puppet::SSL::CertificateRquest#subject_alt_names` method was trying to select all of the subjectAltName extensions in the extension requests, but was accidentally assigning that OID to all extensions instead of comparing them. Before 63cecc56 subjectAltName was the only possible extension request so this was innocuous, but following that commit this error was destructive. This commit resolves the issue by using the comparison operator instead of assignment.
|
CLA signed by all contributors. |
Certificates generated by the Puppet CA come with a number of standard extensions, but users may want to create certs with custom extensions and then retrieve them later. This commit adds a mechanism for adding extension requests to the CSR from the csr_attributes file and exposes custom extensions on the signed certificate.
jpartlow
added a commit
that referenced
this pull request
Nov 19, 2013
…quests Feature/23201/csr extension requests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provides a mechanism for specifying X509 certificate extension requests to be added to the csr for a host and copied into the hosts certificate by the Puppet certificate authority.