Skip to content

(#16570) Don't load the node object again in configurer#2162

Closed
dalen wants to merge 1 commit intopuppetlabs:masterfrom
dalen:double_facts
Closed

(#16570) Don't load the node object again in configurer#2162
dalen wants to merge 1 commit intopuppetlabs:masterfrom
dalen:double_facts

Conversation

@dalen
Copy link
Contributor

@dalen dalen commented Dec 16, 2013

Avoid loading the node object again if we already have a catalog.

In the long run the configurer class should probably be rafactored to have separate methods for fetching a catalog and applying it (and possibly have fetching of catalogs elsewhere).

Not methods like this:

# Retrieve (optionally) and apply a catalog. If a catalog is passed in
# the options, then apply that one, otherwise retrieve it.
def apply_catalog(catalog, options)

Avoid loading the node object again if we already have a catalog.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it is applicable (depends on where the catalog comes from)... did you consider what happens if a node is changed from one environment to another and it has a catalog compiled for the "old" environment. (Not sure if that can happen at all and get to this point).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a catalog already exists at this point it's been intentionally supplied by the user.

@puppetcla
Copy link

CLA signed by all contributors.

@joshcooper joshcooper closed this in 3404db5 Jan 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants