(#16570) Don't load the node object again in configurer#2162
Closed
dalen wants to merge 1 commit intopuppetlabs:masterfrom
Closed
(#16570) Don't load the node object again in configurer#2162dalen wants to merge 1 commit intopuppetlabs:masterfrom
dalen wants to merge 1 commit intopuppetlabs:masterfrom
Conversation
Avoid loading the node object again if we already have a catalog.
Contributor
There was a problem hiding this comment.
Not sure if it is applicable (depends on where the catalog comes from)... did you consider what happens if a node is changed from one environment to another and it has a catalog compiled for the "old" environment. (Not sure if that can happen at all and get to this point).
Contributor
There was a problem hiding this comment.
If a catalog already exists at this point it's been intentionally supplied by the user.
|
CLA signed by all contributors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid loading the node object again if we already have a catalog.
In the long run the configurer class should probably be rafactored to have separate methods for fetching a catalog and applying it (and possibly have fetching of catalogs elsewhere).
Not methods like this: