(PUP-1421) Remove flawed source validation in package provider appdmg.#2249
Merged
kylog merged 1 commit intopuppetlabs:masterfrom Jan 13, 2014
webbj74:fix/master/PUP-1421
Merged
(PUP-1421) Remove flawed source validation in package provider appdmg.#2249kylog merged 1 commit intopuppetlabs:masterfrom webbj74:fix/master/PUP-1421
kylog merged 1 commit intopuppetlabs:masterfrom
webbj74:fix/master/PUP-1421
Conversation
* appdmg's "source" may be a URL that redirects to the actual dmg (and thus not end in .dmg) * actual download is renamed to "name" anyway * hdiutil doesn't require the dmg file to have a filename ending in .dmg
|
CLA signed by all contributors. |
kylog
pushed a commit
that referenced
this pull request
Jan 13, 2014
(PUP-1421) Remove flawed source validation in package provider appdmg.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More Details: https://tickets.puppetlabs.com/browse/PUP-1421